[FIX] Ensure non-agg API doesn't error out when all matches lack pipeline data - Githubissues

neurobagel / api

https://api.neurobagel.org/

MIT License

4 stars 3 forks source link

[FIX] Ensure non-agg API doesn't error out when all matches lack pipeline data #369

Closed alyssadai closed 3 weeks ago

alyssadai commented 3 weeks ago

Fixes #368

Changes proposed in this pull request:

Comments added to clarify steps in graph response reshaping
Add mocked non-aggregated graph response where no subjects have pipeline info
- Add test of API response for this query result case
Handle NaNs for pipeline_name during graph response reshaping, to account for cases where there are no completed pipelines among matching sessions

Checklist

This section is for the PR reviewer

[x] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
[x] PR has a label for the release changelog or skip-release (to be applied by maintainers only)
[x] PR links to GitHub issue with mention Closes #XXXX
[x] Tests pass
[x] Checks pass
[ ] If the PR changes the SPARQL query template, the default Neurobagel query file has also been regenerated

For new features:

[ ] Tests have been added

For bug fixes:

[x] There is at least one test that would fail under the original bug conditions.

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 11565246440

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

29 of 29 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.1%) to 96.655%

Totals
Change from base Build 11522278696:	1.1%
Covered Lines:	809
Relevant Lines:	837

💛 - Coveralls

neurobagel-bot[bot] commented 3 weeks ago

:rocket: PR was released in v0.4.1 :rocket: