neurobagel / bagel-cli

Command line tool for Neurobagel data parsing and annotation
https://neurobagel.org/cli/
MIT License
2 stars 5 forks source link

Create example phenotypic inputs for no-session-layer BIDS case #100

Open alyssadai opened 1 year ago

alyssadai commented 1 year ago

At the moment, we have tests which check that:

What we don't have:

This would test, explicitly, that ses-unnamed ImagingSessions are correctly created from BIDS datasets without sessions, and that the same sessions still have accurate paths to the data. At the moment, the combination of existing tests can be argued to test this implicitly.

To be able to create the above test, we would need:

  1. A BIDS dataset with no session layer (e.g., ds001 or eeg_ds000117 from `bids-examples)
  2. A custom phenotypic JSONLD to provide as input to bagel bids, that includes all subjects in the BIDS dataset above
  3. In order to generate 2., we would need to create: a. a new valid phenotypic TSV with all subjects in the missing-session-layer BIDS dataset b. a corresponding valid Neurobagel data dictionary JSON

Add to tests/data:

github-actions[bot] commented 1 year ago

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days. We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

github-actions[bot] commented 1 year ago

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days. We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

github-actions[bot] commented 8 months ago

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days. We have applied the _flag:stale label to indicate that this issue should be reviewed again. When you review, please reread the spec and then apply one of these three options:

alyssadai commented 4 weeks ago

@surchs I'm rereading this issue I created (quite a while ago) and would like a second opinion on whether this is still worth addressing.

What gives me pause is the potential overhead related to adding these new examples: we will either need a test that runs both the bagel pheno and bagel bids commands, which seems kind of complex, or a new example JSONLD corresponding to another bids-examples dataset (one missing sessions) that we will have to maintain.

Wdyt? Do you think the intended handling of missing sessions in BIDS data is sufficiently covered by existing tests?