Closed alyssadai closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.36%. Comparing base (
e93423d
) to head (e387f06
). Report is 11 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Totals | |
---|---|
Change from base Build 11716298122: | -0.004% |
Covered Lines: | 964 |
Relevant Lines: | 980 |
Hey @surchs, just to reply to your concern regarding the removed test:
I think we already had the case that we didn't include a class in the context and that then breaks things in confusing ways. So I don't think removing the test completely is a solution either
To clarify, we added two new tests in PR #349, test_all_used_namespaces_have_urls
and test_used_namespaces_in_context
, that should catch these issues without requiring us to remember to update the test parameters whenever we update the data model! :) The removed test was just leftover from a #TODO
in that PR.
:rocket: PR was released in v0.3.4
:rocket:
Changes proposed in this pull request:
utilities
moduleutility.py
tomodel_utils.py
(includes utility functions related to generating + extracting entities from graph dataset instances, etc.)test_utility.py
into:test_putil.py
test_butil.py
test_dutil.py
test_futil.py
test_mutil.py
integration/
andunit/
subdirstest_generate_context()
(it replicates logic of function being tested and is hard to maintain)Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: