neurobagel / planning

MIT License
0 stars 0 forks source link

Ignore E203 in flake8 #149

Open surchs opened 4 months ago

surchs commented 4 months ago

flake8 causes false positives of E203 (https://www.flake8rules.com/rules/E203.html) in certain cases

Since black handles this correctly (afaict), let's ignore rule 203 and get the linters to calm down a bit

surchs commented 4 months ago

This will also let us merge https://github.com/neurobagel/bagel-cli/pull/297

surchs commented 4 months ago

One weird aspect is that I haven't been able to reproduce these false positives from flake8 locally. I.e. they only seem to happen as part of the pre-commit CI run

alyssadai commented 4 months ago

Can we close this since https://github.com/neurobagel/bagel-cli/pull/300 is merged?

alyssadai commented 4 months ago

Ignore rule needs to be added to all repos where pre-commit-CI is set up

surchs commented 1 month ago

is there going to be enough overlap on the ignore rules to sync them to all (python) repos? I would assume so