neurobagel / planning

MIT License
0 stars 0 forks source link

Create separate nodes for the PPMI and QPN #44

Closed alyssadai closed 10 months ago

alyssadai commented 10 months ago

Ideally, these datasets would live on two different different databases (with different APIs) in the same graph server.

In order to allow two different APIs to talk to the same graph container, we may need to create a new docker-compose.yml or otherwise connect one of the API container to an existing docker network (see https://docs.docker.com/engine/reference/commandline/network_connect/).

Steps to implement

alyssadai commented 10 months ago

For reviewer, see on st-viateur:

surchs commented 10 months ago

Thanks @alyssadai! All config files look great, excellent choice of credentials. However I am getting error 403 from the QPN API:

{"detail":": Forbidden (HTTP status 403)\n"}

I'm assuming that's not what we want?

alyssadai commented 10 months ago

Thanks for catching that @surchs.

I've re-granted RW permissions to both the mni_qpn and mni_ppmi databases for the database user I set up. If you try to access the QPN API again it should now work.

I've also opened an issue to document the (problem of) non-additive GraphDB permissions here https://github.com/neurobagel/documentation/issues/116.

alyssadai commented 10 months ago

Hey @surchs, following recent discussions about the privacy of QPN I've updated the API config for the mni_qpn database to run in aggregate mode as well.

Let me know if this issue looks good to close now 🙂

surchs commented 10 months ago

@alyssadai I checked the requests and it now works for me with no auth error! Thanks a lot. I think we can close