Decouple version tag from the repo

neurobagel / query-tool

User interface for searching across Neurobagel graph

https://query.neurobagel.org/

MIT License

2 stars 1 forks source link

Decouple version tag from the repo #111

Open surchs opened 5 months ago

surchs commented 5 months ago

Right now we fetch the release number every time any user interacts with the App:

https://github.com/neurobagel/query-tool/blob/9d110ba31119673fe1b6410418e322f296de680b/src/components/Navbar.tsx#L9-L21

This will break real quick with some level of load - and even just from running the e2e test suite a couple of times:

There is really no reason to fetch this at all! The purpose of string is to tell you what version you are running, not what version is available. So this number should get baked into the build of the tool and read at build time from the build context, not from the repository!

surchs commented 5 months ago

I think there is a related problem (without the same performance impact) because we pull the neurobagel logo live every time the app loads for a user - couldn't find the issue for that, so maybe we need to make one

rmanaem commented 4 months ago

There is really no reason to fetch this at all! The purpose of string is to tell you what version you are running, not what version is available. So this number should get baked into the build of the tool and read at build time from the build context, not from the repository!

I agree that it's better to have this baked in somewhere instead of pulling from the repo every time but having it hardcoded and having to update it every time a new release is made seems inefficient.

surchs commented 4 months ago

Agree, we'd need something that runs automatically at release time, but only once

github-actions[bot] commented 2 months ago

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days. We have applied the _flag:stale label to indicate that this issue should be reviewed again. When you review, please reread the spec and then apply one of these three options:

prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this label in the future. Use sparingly!