search

neurobagel / query-tool

User interface for searching across Neurobagel graph
https://query.neurobagel.org/
MIT License
2 stars 1 forks source link

Notistack popups overlapping UI elements #306

Open surchs opened 2 weeks ago

surchs commented 2 weeks ago

Our Auth e2e test in https://github.com/neurobagel/query-tool/pull/300 is failing because the warning popup for "we removed some diagnostics terms" is covering the login button:

Image

Not sure what the best fix here is. The popup is on a timeout, so we could just make the cypress test wait longer than the popup timeout. Or we could actively click the popup away as part of the test setup, but that seems a little messy.

But we need to fix this before #300 can be merged.

surchs commented 2 weeks ago

Might be easiest to just wait until the warning auto-closes after 4000ms (?)

rmanaem commented 2 weeks ago

Given this behavior is due to querying the production API (and getting missing data in response), I think a better approach would be to mock the response to fix this bug. wdyt @surchs ?

surchs commented 2 weeks ago

Hhm, yes, I agree that in this case we should mock the call because we don't want to rely on the prod API for the tests to run. But as we have discovered the more general issue of warning prompts hiding important UI elements, we still have to address the original issue - so it doesn't come back.

How about we do this:

  1. Make a new issue to mock all API calls instead of relying on the prod API
  2. Put that new issue high on the backlog directly
  3. Move this current issue off the backlog but keep it open as a reminder to fix the general issue of warnings overlapping UI