[ENH] Set up API for uploading files to a repo - Githubissues

neurobagel / tools

Other helpful tools for interfacing with Neurobagel

MIT License

0 stars 0 forks source link

[ENH] Set up API for uploading files to a repo #2

Closed alyssadai closed 7 months ago

alyssadai commented 7 months ago

Closes #

Changes proposed in this pull request:

Set up API PUT route for updating a file in a repo (using neurobagel/test_json for now)
Add response models for successful upload, successful upload w/ warning, and failed upload
Validate request body (data dictionary) using CLI utility functions
- dictionary_utils.py, mappings.py, and dictionary_models.py are taken from the CLI
Add check that request body contents are different than file to be changed

Checklist

This section is for the PR reviewer

[x] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
[ ] PR links to GitHub issue with mention Closes #XXXX
[ ] Tests pass
[ ] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

alyssadai commented 7 months ago

@surchs, let me know if you have any ideas for refactoring the main PUT route function for testing, or if any of the #TODOs make sense to you for addressing as part of this PR.

neurobagel-bot[bot] commented 2 months ago

:rocket: PR was released in v0.1.0 :rocket: