search

neurobionics / opensourceleg

An open-source software library for numerical computation, data acquisition, and control of lower-limb robotic prostheses.
https://opensourceleg.org
GNU Lesser General Public License v2.1
29 stars 33 forks source link

Refactoring units.py to increase usability. #283

Open shreyhas opened 2 hours ago

shreyhas commented 2 hours ago

🚀 Feature Request

Units.py should globally define the units used by the user. All values will be input and output in the defined units.

🔈 Motivation

Currently, units.py allows for converting to and from default units. With this, you can convert between units but this is an uneccessary line that needs to be added by the user. This processing should happen on the back-end.

🛰 Alternatives

Instead of picking individual units, we could only allow the user to control the system of units used.

📎 Additional context

N/A

github-actions[bot] commented 2 hours ago

Hello @shreyhas, thank you for your interest in our work!

If this is a bug report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

tkevinbest commented 2 hours ago

We thought about this at the beginning of the units module, but we decided that explicitly setting units was safer. Many codebases/sensors force you to to mix and match units, so rarely do we work in only one unit system.