Closed cshen6 closed 7 years ago
@jovo I looked through the graph testing draft carefully. The paper structure is perfect; but writings need to be optimized with many parts rewritten, rather than slight polish. We should discuss how to proceed on it this Monday.
Figure-wise detailing (important for paper, can wait after your oral done): @youjin
Overall, they are all minor formatting issues. In particular, try to guarantee consistent and text-size fonts throughout all labels and figure titles. Appendix figures also follow the same rule.
great. i'd like to make sure we got the story "right" before dwelling too much on figure details.
is there a bulleted list of just the 1 sentence "take home" message from each figure? if that tells our complete story, then we are ready to go :)
On Sun, Nov 27, 2016 at 7:56 PM, cshen6 notifications@github.com wrote:
@jovo https://github.com/jovo I looked through the graph testing draft carefully. The paper structure is perfect; but writings need to be optimized with many parts rewritten, rather than slight polish. We should discuss how to proceed on it this Monday.
Figure-wise detailing (important for paper, can wait til your oral done): @youjin https://github.com/youjin
- figure 1: enlarge legend font size to align with text size
- figure 2: the colorbar fonts are still too small and conflicts with colorbar. Also only use 3 ticks (e.g., 0, 0.5, 1), and inward ticks. Also, I am not sure whether the attributes X beside A is informative at all, this needs change after discussing.
- figure 3: Same colorbar fonts and tick issue.
- figure 4: Same colorbar change, i.e., no need for distribution, colorbar axis tick simplify and larger font. Also, the y label "metric" should either be put on the left of the figure, or facing the figure (rotate 180). Also, slightly enlarge all font sizes of labels here.
- figure 5: larger font size everywhere, including legend, labels, ticks. Thicken the red and blue lines. Inward x and y ticks.
- figure 6: The font size here is pretty good! But the y label power is a bit too large comparing to x label text. Also thicken lines, inward ticks.
- figure 7: Thicken lines, and line color and style should match with figure 6, and make figure 6 & 7 into a same figure with two panels & one single legend.
- figure 8: fonts, line thicken, inward ticks.
- figure 9: on the left, can you make the three isolated vertices closer to the left panel (they are too close to the right panel). Also slightly larger font size.
Overall, they are all minor formatting issues. In particular, try to guarantee consistent and text-size fonts throughout all labels and figure titles. Appendix figures also follow the same rule.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/neurodata/Multiscale-Network-Test/issues/19#issuecomment-263161353, or mute the thread https://github.com/notifications/unsubscribe-auth/AACjcgmOm7VvITqa-hkt8u9Zy-w1rIOaks5rCibCgaJpZM4K5eKy .
-- the glass is all full: half water, half air. neurodata.io, jovo calendar https://calendar.google.com/calendar/embed?src=joshuav%40gmail.com&ctz=America/New_York
We have stories for each figure (probably except figure 1, which is the introductory figure), and we can test youjin tmr to see if her answer satisfies you :-)
So yes, we have a complete story here from what I saw.
@cshen6 I've edited other figures but not figure 2,3 and 4 which are basically heatmap. Do you have any recommendation of R function? The main problem is that I cannot handle axes in color key. I will get back to this work on Thursday. Thank!
@cshen6 I fixed the figures and updated them in draft/outline. Can you please have a look at it and give some comments? Plus, FYI, Slack on my laptop shut down so often.
@youjin1207 no problem, I will look at it next week, comments & rewrite some if necessary.
Then we will have jovo reading it next Monday or before, consolidating comments & send for JSM.
Thanks! I might have minor changes during that time.
thanks for the figure update!! And you solved the colorbar font issue!!
Three more
Other than that, it is all good with me.
Ok, tell me when it is my turn :)
On Mon, Dec 5, 2016 at 2:40 PM cshen6 notifications@github.com wrote:
thanks for the figure update!! And you solved the colorbar font issue!!
Three more
figure 2 (c) and (d), use || . || for distances, rather than | . |.
the colorbar font of figure 4 is a bit too large now :-). Also the cross mark is now missing for FH?
figure 6, the location of (a) and (b) are not correctly aligned.
Other than that, it is all good with me.
—
You are receiving this because you were mentioned.
Reply to this email directly,
view it on GitHub https://github.com/neurodata/Multiscale-Network-Test/issues/19#issuecomment-264954422, or
mute the thread https://github.com/notifications/unsubscribe-auth/AACjcjBI2Pmr957xxT0b7TVeQ8cGUT2Hks5rFGh4gaJpZM4K5eKy .
We are done with all major contents, so it is good time to polish paper!
Post youjin's talk, I plan to slightly adjust: