neurodata / ProgLearn

NeuroData's package for exploring and using progressive learning algorithms
https://proglearn.neurodata.io
Other
35 stars 42 forks source link

Scene Segmentation on ISIC using RF #536

Closed amyvanee closed 2 years ago

amyvanee commented 2 years ago

Reference issue

Continued progress on issue #39 on scene segmentation.

Type of change

Added

Fixed black formatting of documents

What does this implement/fix?

Added another tutorial on scene segmentation using rf on ISIC dataset and fixed formatting of pre-existing files

Additional information

Neuro Data Design II, Spring 2022

codecov[bot] commented 2 years ago

Codecov Report

Merging #536 (418944c) into staging (d246c60) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           staging     #536   +/-   ##
========================================
  Coverage    90.09%   90.09%           
========================================
  Files            7        7           
  Lines          404      404           
========================================
  Hits           364      364           
  Misses          40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db0c6f8...418944c. Read the comment docs.

amyvanee commented 2 years ago

@amyvanee you need to also comment what other files you corrected to pass the style checks.

Updated my comment, thank you!

jdey4 commented 2 years ago

I see 2 scene segmentation tutorials in docs/tutorial which should be in docs/experiment.

amyvanee commented 2 years ago

This file belongs to docs/tutorial, right?

Yes! They were from benchmarks/cifar_exp, proglearn/tests and proglearn/sims

amyvanee commented 2 years ago

I see 2 scene segmentation tutorials in docs/tutorial which should be in docs/experiment.

should these go under experiments instead? The notebooks we had previously were placed under tutorial?

jdey4 commented 2 years ago

@amyvanee I would get rid of the "Dimensions of Images" blocks. The scatter plots are not informative. And why does the precision-recall curve show some dots instead of a continuous curve?

jdey4 commented 2 years ago

I see 2 scene segmentation tutorials in docs/tutorial which should be in docs/experiment.

should these go under experiments instead? The notebooks we had previously were placed under tutorial?

@amyvanee they should be in the experiments folder. The location for the current PR is correct. But it was not correct for the PRs last semester.

amyvanee commented 2 years ago

I see 2 scene segmentation tutorials in docs/tutorial which should be in docs/experiment.

should these go under experiments instead? The notebooks we had previously were placed under tutorial?

@amyvanee they should be in the experiments folder. The location for the current PR is correct. But it was not correct for the PRs last semester.

Sounds good, thank you! I also fixed the precision-recall curve and removed the unnecessary information about the dimensions of images.

amyvanee commented 2 years ago

@amyvanee Check your website preview and fix the math equation. Other than that LGTM.

Fixed, thank you!!