neurodata / hyppo

Python package for multivariate hypothesis testing
https://hyppo.neurodata.io/
Other
215 stars 90 forks source link

fix dcorr sqrt bug #385

Closed sampan501 closed 1 year ago

sampan501 commented 1 year ago

Reference issue

Closes #384

Type of change

Bug

What does this implement/fix?

Takes square root of Dcorr test statistic and fixes fast Dcorr so statistic is calculated as before.

Additional information

netlify[bot] commented 1 year ago

Deploy Preview for hyppo ready!

Name Link
Latest commit fa377e5ab77bf5fc326a89d4e3ca3491e3348847
Latest deploy log https://app.netlify.com/sites/hyppo/deploys/6491c71fd38fdf00082b5f08
Deploy Preview https://deploy-preview-385--hyppo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (50f9c68) 96.70% compared to head (fa377e5) 96.71%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #385 +/- ## ======================================= Coverage 96.70% 96.71% ======================================= Files 86 86 Lines 3886 3891 +5 ======================================= + Hits 3758 3763 +5 Misses 128 128 ``` | [Impacted Files](https://app.codecov.io/gh/neurodata/hyppo/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neurodata) | Coverage Δ | | |---|---|---| | [hyppo/independence/tests/test\_kmerf.py](https://app.codecov.io/gh/neurodata/hyppo/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neurodata#diff-aHlwcG8vaW5kZXBlbmRlbmNlL3Rlc3RzL3Rlc3Rfa21lcmYucHk=) | `87.50% <ø> (ø)` | | | [hyppo/independence/tests/test\_maxmargin.py](https://app.codecov.io/gh/neurodata/hyppo/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neurodata#diff-aHlwcG8vaW5kZXBlbmRlbmNlL3Rlc3RzL3Rlc3RfbWF4bWFyZ2luLnB5) | `100.00% <ø> (ø)` | | | [hyppo/independence/dcorr.py](https://app.codecov.io/gh/neurodata/hyppo/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neurodata#diff-aHlwcG8vaW5kZXBlbmRlbmNlL2Rjb3JyLnB5) | `97.67% <100.00%> (ø)` | | | [hyppo/independence/tests/test\_dcorr.py](https://app.codecov.io/gh/neurodata/hyppo/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neurodata#diff-aHlwcG8vaW5kZXBlbmRlbmNlL3Rlc3RzL3Rlc3RfZGNvcnIucHk=) | `100.00% <100.00%> (ø)` | | | [hyppo/ksample/tests/test\_ksamp.py](https://app.codecov.io/gh/neurodata/hyppo/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neurodata#diff-aHlwcG8va3NhbXBsZS90ZXN0cy90ZXN0X2tzYW1wLnB5) | `100.00% <100.00%> (ø)` | | | [hyppo/tools/common.py](https://app.codecov.io/gh/neurodata/hyppo/pull/385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neurodata#diff-aHlwcG8vdG9vbHMvY29tbW9uLnB5) | `94.17% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.