search

neurodata / mgcpy-old

MGCPY WILL NO LONGER BE UPDATED. THE NEW REPO CAN BE FOUND HERE:
https://github.com/neurodata/hyppo
Apache License 2.0
31 stars 45 forks source link

Factor out requirements.txt #103

Open j1c opened 5 years ago

j1c commented 5 years ago

Can these be factored out into a separate requirements for testing? Some of these conflict with my own installed versions and they don't need to be installed for mgcpy to work..

pytest>=3.8.0 flake8>=3.5.0 pycodestyle>=2.3.1 pytest-cov>=2.6.0 coveralls>=1.5.1 Sphinx>=1.8.2 h5py>=2.7.1

FYI, you can have travis install these separately.

tpsatish95 commented 5 years ago

Yeah, that makes sense, mgcpy needs only 4 of them. I have updated the setup.py here: https://github.com/neurodata/mgcpy/blob/satish/setup.py#L32. So that, only the minimal packages are installed when mgcpy is installed. Does this work? Or should the requirements.txt also be slimmed down?

j1c commented 5 years ago

I think it makes sense to make a second requirements called like requirements_testing.txt or something like that. Theres no real standard for this so whatever you think is easiest. I personally just have all dependencies for testing in travis.yml.