neurodata / mgcpy-old

MGCPY WILL NO LONGER BE UPDATED. THE NEW REPO CAN BE FOUND HERE:
https://github.com/neurodata/hyppo
Apache License 2.0
31 stars 45 forks source link

Don't base random seed on floored clock time #161

Closed bdpedigo closed 5 years ago

bdpedigo commented 5 years ago

Describe the bug Discretized p-values due to basing random seed off floored clock time

To Reproduce Run DCorr (or I think any test) on something relatively fast such that more than one iteration happens in a second

Expected behavior Different p-values due to different permulations

Screenshots With np.random.seed(int(time.time()))

Screen Shot 2019-07-22 at 4 07 58 PM

After removing that line in abstract_class.py

Screen Shot 2019-07-22 at 4 08 24 PM