search

neurodata / ndstore

code for storing neurodata images and image annotations
http://neurodata.io
Apache License 2.0
38 stars 12 forks source link

Added trailing slash to nduser paths #268

Closed tmbo closed 8 years ago

tmbo commented 8 years ago

When running locally without nginx, paths missing a trailing / lead to an automatic redirect (django default). During that redirect, the script prefix /nd gets prepended again which results in urls like /nd/nd/nduser/projects/ which is invalid.

This PR fixes the issue by adding the trailing / to all nduser redirects.

Furthermore, for the future one should consider to either remove the script prefix FORCE_SCRIPT_NAME or set APPEND_SLASH to false.

tmbo commented 8 years ago

Hey @kunallillaney. I just wanted to check what the review process for this repo looks like? Whats the expected time frame?

kunallillaney commented 8 years ago

@tmbo We do not have a review process per se. I do not have tests which cover the part of the code to which you have made changes. I will get around to look at them later this week and merge it with the current dev branch. Let me know if you have further questions. Thanks for the pull requests.

jovo commented 8 years ago

@tmbo super awesome to receive your pull request! the more feedback and PR's we get, the better for us....