search

neurodata / ndstore

code for storing neurodata images and image annotations
http://neurodata.io
Apache License 2.0
38 stars 12 forks source link

ndio doesn't fail if a channel is created and the underlying tables exist #323

Closed alexbaden closed 8 years ago

alexbaden commented 8 years ago

E.g., I create the channel test using the console. I then delete test, but the delete fails and a table still remains. I then re-create test using ndio. The creation should fail, because the channel creation fails (e.g. Failed to create channel. "Failed to create tables for new project 1050: Table 'test_ramon' already exists.") but it doesn't.

Documenting here because the ndio error checking is pretty well implemented for create_channel. Pretty sure it's a problem on the ndstore end...

kunallillaney commented 8 years ago

Which branch is this and what kvengine?

alexbaden commented 8 years ago

microns / mysql

alexbaden commented 8 years ago

The point of this issue is if channel creation fails in the ndstore web console, it should also fail in the create channel JSON endpoint, which it currently doesn't seem to.

kunallillaney commented 8 years ago

can you give me sample call which ndio is making which seems to succeed.

kunallillaney commented 8 years ago

For the record, the issue was in NDIO but the backend now should work.