neurodata / ndstore

code for storing neurodata images and image annotations
http://neurodata.io
Apache License 2.0
38 stars 12 forks source link

Authentication Tests #430

Open Aeusman opened 7 years ago

Aeusman commented 7 years ago

[On Hold] - Pending a decision about how we want to deal with the new setup script in 16.

kunallillaney commented 7 years ago

@Aeusman Here is what I recommend: We should create multiple modes of the same test. One mode runs all these tests as they are on public projects(which is the case now) and have a second mode which runs against all private projects with a pre-created token(as you had earlier). Let's create a token on install (only when installing on travis) and go thorough mode1 and mode2. We can set this mode via providing a conditional command-line argument to py.test which defaults always to mode1. Does this sound reasonable?

Aeusman commented 7 years ago

Sounds reasonable to me. I'll implement this probably inside test_settings, and do something inside the trais model to test in this way. It might be challenging to do this in a purely py.test environment.

kunallillaney commented 7 years ago

I don't think test_settings will work since we want to run both tests. Let's discuss this offline.