search

neurodata / scikit-learn

scikit-learn-tree fork: A fork that enables extensions of Python and Cython API for decision trees
https://scikit-learn.org
BSD 3-Clause "New" or "Revised" License
7 stars 6 forks source link

Bring in monotonicity #47

Closed adam2392 closed 1 year ago

adam2392 commented 1 year ago

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

github-actions[bot] commented 1 year ago

❌ Linting issues

This PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling pre-commit hooks. Instructions to enable them can be found here.

You can see the details of the linting issues under the lint job here

ruff

ruff detected issues. Please run ruff --fix --show-source . locally, fix the remaining issues, and push the changes. Here you can see the detected issues. Note that the installed ruff version is ruff=0.0.277.

``` sklearn/ensemble/_forest.py:2293:1: W293 [*] Blank line contains whitespace | 2292 | .. versionadded:: 0.22 2293 | | ^^^^ W293 2294 | max_bins : int, default=255 2295 | The maximum number of bins to use for non-missing values. | = help: Remove whitespace from blank line Found 1 error. [*] 1 potentially fixable with the --fix option. ```

cython-lint

cython-lint detected issues. Please fix them locally and push the changes. Here you can see the detected issues. Note that the installed cython-lint version is cython-lint=0.15.0.

``` /home/runner/work/scikit-learn/scikit-learn/sklearn/tree/_splitter.pyx:303:1: W293 blank line contains whitespace /home/runner/work/scikit-learn/scikit-learn/sklearn/tree/_tree.pyx:360:24: dict key n_constant_features repeated 2 times ```

Generated for commit: a472aa1. Link to the linter CI: here