Closed PSSF23 closed 1 year ago
This PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling pre-commit
hooks. Instructions to enable them can be found here.
You can see the details of the linting issues under the lint
job here
black
black
detected issues. Please run black .
locally and push the changes. Here you can see the detected issues. Note that running black might also fix some of the issues which might be detected by ruff
. Note that the installed black
version is black=23.3.0
.
ruff
ruff
detected issues. Please run ruff --fix --show-source .
locally, fix the remaining issues, and push the changes. Here you can see the detected issues. Note that the installed ruff
version is ruff=0.0.284
.
Thanks for the notes! I'm still cleaning up the merging conflicts and will get back to your reviews once I have the code running again.
Kay I cleaned the diff by merging in changes from sklearn:main
to submodulev2
and then to this branch.
Do you have unit-tests you can port from your old PR? The CIs can help check these whenever we get new stuff that way.
@adam2392 I have revamped the
update
cython function intobuild
as we discussed in #35. Right now I only modifiedDepthFirstTreeBuilder
as there's no way to control max depth in streaming trees.