search

neurodata / scikit-tree

Scikit-learn compatible decision trees beyond those offered in scikit-learn
https://docs.neurodata.io/scikit-tree/dev/index.html
Other
54 stars 13 forks source link

ENH treeple tutorials should use native functions in scikit-tree #257

Closed sampan501 closed 3 weeks ago

sampan501 commented 2 months ago

From #256:

We should fix the tutorials to use native functions in scikit-tree, like build_coleman_forest etc. It should be clear to the user that they don't need to write their own custom function to compute a p-value using MIGHT.

PSSF23 commented 2 months ago

Jovo wants to add a figure similar to this one, which would require all the intermediate statistics (the ones that 2 permuted forest make). build_coleman_forest doesn't return those values, unfortunately, so I'll postpone the conversion for now.

sampan501 commented 2 months ago

Sure, we could write it like this instead. Show all the intermediate stats figures, and at the end show how to compute the stat and p-value using treeple

adam2392 commented 2 months ago

The statistics we need are the null distribution? What else?

adam2392 commented 3 weeks ago

I assume this has been addressed in #280 and #273. Feel free to reopen if not.