Closed adam2392 closed 6 months ago
Attention: Patch coverage is 87.87879%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 90.04%. Comparing base (
f957cdb
) to head (3479b8e
).
Files | Patch % | Lines |
---|---|---|
sktree/tree/_multiview.py | 86.66% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Doc error and failing on AMD machines?
It should be fixed now
Updates scikit-tree wrt scikit-learn fork
Changes proposed in this pull request:
cnp
import în Cython files where possible_update_tree
function to re-define a splitter (inefficient use of code tho; see https://github.com/neurodata/scikit-learn/issues/64). This is done, so we don't have to pickle the splitter and builder and it works properly w/ the new code in submodule.X
.ParentInfo
andSplitRecord
when passing information back and forth between tree and splitter (see: https://github.com/scikit-learn/scikit-learn/pull/28614#pullrequestreview-1974604803)cc: @sampan501 @SUKI-O this may be useful for reviewing so you understand what Cython changes are happening
Before submitting
CONTRIBUTING
docs.CONTRIBUTING
docs.After submitting