MAINT Update submodule commit and remove cnp imports where possible

adam2392 commented 7 months ago

Updates scikit-tree wrt scikit-learn fork

Changes proposed in this pull request:

Remove cnp import în Cython files where possible
Make every tree class define _update_tree function to re-define a splitter (inefficient use of code tho; see https://github.com/neurodata/scikit-learn/issues/64). This is done, so we don't have to pickle the splitter and builder and it works properly w/ the new code in submodule.
Makes the trees not pickle the builder/splitter, otw can incur a huge storage cost since technically the splitter stores X.
Updates to use ParentInfo and SplitRecord when passing information back and forth between tree and splitter (see: https://github.com/scikit-learn/scikit-learn/pull/28614#pullrequestreview-1974604803)

cc: @sampan501 @SUKI-O this may be useful for reviewing so you understand what Cython changes are happening

Before submitting

[ ] I've read and followed all steps in the Making a pull request section of the CONTRIBUTING docs.
[ ] I've updated or added any relevant docstrings following the syntax described in the Writing docstrings section of the CONTRIBUTING docs.
[ ] If this PR fixes a bug, I've added a test that will fail without my fix.
[ ] If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

[ ] All GitHub Actions jobs for my pull request have passed.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.04%. Comparing base (f957cdb) to head (3479b8e).

Files	Patch %	Lines
sktree/tree/_multiview.py	86.66%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #249 +/- ## ========================================== - Coverage 90.05% 90.04% -0.02% ========================================== Files 54 54 Lines 5050 5105 +55 ========================================== + Hits 4548 4597 +49 - Misses 502 508 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adam2392 commented 6 months ago

Doc error and failing on AMD machines?

It should be fixed now

neurodata / treeple