MAINT `HonestForestClassifier` now has `bootstrap=True` as the default. And removing old MIGHT code - Githubissues

neurodata / treeple

Scikit-learn compatible decision trees beyond those offered in scikit-learn

https://treeple.ai

Other

65 stars 14 forks source link

MAINT `HonestForestClassifier` now has `bootstrap=True` as the default. And removing old MIGHT code #274

Closed adam2392 closed 4 months ago

adam2392 commented 5 months ago

Fixes #146

Changes proposed in this pull request:

bootstrap=True is the default now
Removed all instances of FeatureImportanceClassifier and other MIGHT methods that are outdated. This is in favor of the functional API used for (CO)MIGHT
There was a small bug in build_coleman_forest stemming from #281 and #257 where the PermutationHonestForest should get passed covariate_index. It is not tested in test_comight_repeated_feature_sets.

Before submitting

[ ] I've read and followed all steps in the Making a pull request section of the CONTRIBUTING docs.
[ ] I've updated or added any relevant docstrings following the syntax described in the Writing docstrings section of the CONTRIBUTING docs.
[ ] If this PR fixes a bug, I've added a test that will fail without my fix.
[ ] If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

[ ] All GitHub Actions jobs for my pull request have passed.

sampan501 commented 4 months ago

Pending unit test pass