search

neurodata / treeple

Scikit-learn compatible decision trees beyond those offered in scikit-learn
https://treeple.ai
Other
61 stars 14 forks source link

dropped bottleneck warning message #311

Closed ryanhausen closed 3 weeks ago

ryanhausen commented 1 month ago

Reference Issues/PRs

Fixes #310

What does this implement/fix? Explain your changes.

Drops a bottleneck warning that appears every import of treeple.stats, which can be too much if the user isn't using the functions that depend on bottleneck for nans.

Any other comments?

Rather than move the warning, it makes sense to drop it for now. I am working on a sparse implementation of some of the treeple.stats calculations that will involve a refactor and so the warning may have a better home somewhere else when I am done.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.64%. Comparing base (e8c7de5) to head (91f6271). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #311 +/- ## ========================================== - Coverage 78.66% 78.64% -0.02% ========================================== Files 24 24 Lines 2264 2262 -2 Branches 417 417 ========================================== - Hits 1781 1779 -2 Misses 352 352 Partials 131 131 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adam2392 commented 1 month ago

We can wait to see the sparse refactor then. I think a warning message is still warranted when the user uses the relevant functions (not during import)

ryanhausen commented 3 weeks ago

Closing this out. #317 has this incorporated into it.