search

neurodatascience / dFC

An implementation of several well-known dynamic Functional Connectivity assessment methods.
MIT License
11 stars 5 forks source link

Add support for numpy array is input. #25

Open SebastianVolkmer opened 5 months ago

SebastianVolkmer commented 5 months ago

Hi, given your provided code:

measure = SLIDING_WINDOW(**params_methods) dFC = measure.estimate_dFC(time_series=BOLD)

It would seem easier if that function also works with a simple numpy array containing the channels and time series, without needing, for example, a subject list. This would also simplify the integration of a nilearn workflow.

Thanks and best wishes

mtorabi59 commented 1 month ago

Hi @SebastianVolkmer ,

Thank you so much for bringing this up. I agree with you that if these functions were able to handle a simple numpy array, it would be much more convenient. However, since the whole toolbox is designed to work with particular classes like TIME_SERIES and DFC, and these classes require more information than only the BOLD time series values, as the information is actually necessary for the dFC assessment process and the subsequent analyses, it is not possible to include such option. Nevertheless, we will consider your suggestion and will think of a way to implement it!

Thanks a lot for using PydFC!