Closed michellewang closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 52.66%. Comparing base (
cccdbf6
) to head (d6785a9
).:exclamation: Current head d6785a9 differs from pull request most recent head 8a37516
Please upload reports for the commit 8a37516 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes #225
Remaining TODOs
DicomDirMap
Summary:
pydicom
header check for whetherImageType
contains"DERIVED"
<DATASET_ROOT>/scratch/raw_dicom
):DICOM_DIR_MAP_FILE
: custom CSV withparticipant_id
,session
andparticipant_dicom_dir
columnsDICOM_DIR_PARTICIPANT_FIRST
: alternative option for choosing between<DATASET_ROOT>/scratch/raw_dicom/<PARTICIPANT_ID>/<SESSION>
(default) or<DATASET_ROOT>/scratch/raw_dicom/<SESSION>/<PARTICIPANT_ID>
caplog
fixture work)participant_id
cannot havesub-
prefix, andsession
must haveses-
prefix)Note that this ONLY allows the contents of
raw_dicom
to be somewhat arbitrary. Forsourcedata
I think it makes more sense to enforce<PARTICIPANT_ID>/<SESSION>
, though that might break some of the existing PPMI/QPN data. But I think it is better for things to already be more BIDS-like after the reorg step.