search

neurodsp-tools / neurodsp

Digital signal processing for neural time series.
https://neurodsp-tools.github.io/
Apache License 2.0
281 stars 61 forks source link

[ENH] - Add autocorrelation related functionality #331

Closed TomDonoghue closed 1 month ago

TomDonoghue commented 5 months ago

When doing the Aperiodic Methods project, I ended up using some autocorrelation related funtionality - notably measuring AC decay times, and fitting functions to AC curves - that I think might as well live in neurodsp.

I adapted the functions here from @rdgao's field echos / knee project

TomDonoghue commented 1 month ago

Thanks for the review @ryanhammonds - I've pushed some updates that I think cleans things up and addresses the issue you addressed. I'm going to merge this in now, since I'm trying to consolidate some branches to use the new version in a project - if there is anything to follow up on here we can do another PR and make sure to address it before tagging the next version!

I also agree that once the next specparam version comes together with the additiona models, we can revisit the alignment between methods and see what should be added where!