search

neurofractal / analyse_OPMEG

Nic & Rob's lair of scripts to analyse OPM data, using the Fieldtrip toolbox
https://neurofractal.github.io/analyse_OPMEG/
MIT License
9 stars 1 forks source link

Compatibility with new acquisition system ft_opm_psd #45

Closed meaghanspedden closed 11 months ago

meaghanspedden commented 11 months ago

The sampling frequency is not an integer for the new OPM acq system so nsamps line 211 is not an integer which creates problems for preallocating in line 220. I guess the best solution is just to add floor to line 211?

neurofractal commented 11 months ago

It's not an integer - what is it?!

meaghanspedden commented 11 months ago

It is 374.9998 :)

Den ons. 4. okt. 2023 kl. 13.10 skrev Robert Seymour < @.***>:

It's not an integer - what is it?!

— Reply to this email directly, view it on GitHub https://github.com/neurofractal/analyse_OPMEG/issues/45#issuecomment-1746748548, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJKAFAQRYTXRNDGBSJ3P6TX5VG4XAVCNFSM6AAAAAA5SQLXACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBWG42DQNJUHA . You are receiving this because you authored the thread.Message ID: @.***>

neurofractal commented 11 months ago

Of course it is 😃 !!! Yeah floor sounds sensible. Do you want to submit a pull request or should I just do it?

meaghanspedden commented 11 months ago

Go ahead and do it if you are looking at it now :) thanks

Den ons. 4. okt. 2023 kl. 13.18 skrev Robert Seymour < @.***>:

Of course it 😃 !!! Yeah floor sounds sensible. Do you want to submit a pull request or should I just do it?

— Reply to this email directly, view it on GitHub https://github.com/neurofractal/analyse_OPMEG/issues/45#issuecomment-1746761089, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJKAFAKXKLU7N4VW62JMZTX5VHZTAVCNFSM6AAAAAA5SQLXACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBWG43DCMBYHE . You are receiving this because you authored the thread.Message ID: @.***>

neurofractal commented 11 months ago

https://github.com/neurofractal/analyse_OPMEG/commit/166b81613d6d57bc8f5b51dbd317d811d4393b51

Let me know if it works...

meaghanspedden commented 11 months ago

will take a look now thanks

Den ons. 4. okt. 2023 kl. 13.26 skrev Robert Seymour < @.***>:

166b816 https://github.com/neurofractal/analyse_OPMEG/commit/166b81613d6d57bc8f5b51dbd317d811d4393b51

Let me know if it works...

— Reply to this email directly, view it on GitHub https://github.com/neurofractal/analyse_OPMEG/issues/45#issuecomment-1746773250, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJKAFGIFBHHPCOHCRCDG3TX5VIXHAVCNFSM6AAAAAA5SQLXACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBWG43TGMRVGA . You are receiving this because you authored the thread.Message ID: @.***>

meaghanspedden commented 11 months ago

Yep works great

Den ons. 4. okt. 2023 kl. 13.26 skrev Robert Seymour < @.***>:

166b816 https://github.com/neurofractal/analyse_OPMEG/commit/166b81613d6d57bc8f5b51dbd317d811d4393b51

Let me know if it works...

— Reply to this email directly, view it on GitHub https://github.com/neurofractal/analyse_OPMEG/issues/45#issuecomment-1746773250, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKJKAFGIFBHHPCOHCRCDG3TX5VIXHAVCNFSM6AAAAAA5SQLXACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBWG43TGMRVGA . You are receiving this because you authored the thread.Message ID: @.***>