percentage overlap plots: improvements

[bschilder]

• [x] display % numbers on the heatmap plot squares

overlap_heatmap has new arg draw_cellnote. Works for both static and interactive version of the plot.

• [x] mask the diagonal for the heatmap and the correlation plot

Now rendered as transparent cells.

• [x] Show percentage in the upset plot

This functionality is not currently offered within UpSetR so may need to switch packages: https://github.com/hms-dbmi/UpSetR/issues/183

That said, here are workarounds offered by ComplexUpset: https://krassowski.github.io/complex-upset/articles/Examples_R.html#showing-percentages

This has a ton ways to display overlaps including % .

[bschilder]

Actually, you currently can't have it all for heatmaps.

• cellnote labels don't work in plotly
• NAs in diagonal don't work in heatmaply: https://github.com/talgalili/heatmaply/issues/11
• ggplot2 can do both, but it's not interactive, and plotly::ggplotly() doesn't translate cellnote labels properly: https://stackoverflow.com/questions/42560957/how-to-write-a-text-into-plotly-heat-map-in-r

So for now, whendraw_cellnote=TRUE , I'll use heatmaply but avoid usingfill_diag.

check_heatmap_args <- function(draw_cellnote,
                               interact,
                               fill_diag,
                               verbose=TRUE){
  if(isTRUE(draw_cellnote) && isTRUE(interact)){
    check_dep("heatmaply")
    if(!is.null(fill_diag)){
      messager("Warning: fill_diag must =NULL",
               "due to a known bug in the package 'heatmaply'.",v=verbose)
      fill_diag <- NULL
    } 
  }
  return(fill_diag)
}