Likely bug if dendro is set to Null

neurogenomics / MAGMA_Celltyping

Find causal cell-types underlying complex trait genetics

https://neurogenomics.github.io/MAGMA_Celltyping

71 stars 31 forks source link

Likely bug if dendro is set to Null #127

Closed AMCalejandro closed 1 year ago

AMCalejandro commented 1 year ago

https://github.com/neurogenomics/MAGMA_Celltyping/blob/8cb235fb495a467fb825819a76b2f154d3840146/R/plot_celltype_associations.r#L163

I think this is likely to fail if I do not want to get a dendogram

bschilder commented 1 year ago

This function has been rewritten to make a number of improvements, including avoiding the scenario described here. Implemented in MAGMA.Celltyping v2.0.8