Maybe allow user to decide on how to adjust

neurogenomics / MAGMA_Celltyping

Find causal cell-types underlying complex trait genetics

https://neurogenomics.github.io/MAGMA_Celltyping

71 stars 31 forks source link

Maybe allow user to decide on how to adjust #134

Open AMCalejandro opened 1 year ago

AMCalejandro commented 1 year ago

https://github.com/neurogenomics/MAGMA_Celltyping/blob/8cb235fb495a467fb825819a76b2f154d3840146/R/calculate_celltype_associations.r#L136

Hi Brian,

Please, read here from the MAGMA manual

bschilder commented 1 year ago

I'm not really clear on what the request is here. Could you please explain what you're hoping for @AMCalejandro ?

Please use the Feature Request template. https://github.com/neurogenomics/MAGMA_Celltyping/issues/new/choose

AMCalejandro commented 1 year ago

Yes, so maybe instead of assuming that I want to adjust with a Zscore, giving the user some freedom to decide whether to adjust with Zscore or the log of the P-value ,...

It has been a while, I think that is what I had in mind