Open bschilder opened 3 months ago
This was actually due to a mapping issue between Disease IDs and the Disease Names. The HPO does not currently provide all of the disease names in their annotation files, so I was previously trying to hack together a solution to this.
Fortunately, HPO just released a new API to access this sort of info. I wrote a new function to query their API thousands of times to collect this information (parallelised to speed this up). I've cached this ID-name map and have included a function that uses it to better map the disease names in the gene association data.
I think this is justified in this particular example, as the addition of the previously missing diseases and genes makes the network plot more complex. Removing RNI as a node reduces the number of plotted connections and makes it a bit easier to read. I also added connection from the disease to the gene (in addition from the disease to the cell type) to make the connection between "C7 deficiency" and the C7 gene more obvious.
Preview:
I think this might work better as a heatmap underneath the network plot
"We should be using this figure on a place to explain in more detail how and why all this works. We should show a gnomad-style plot for one of the genes showing where pathogenic variants with known clinical effects associated with the phenotype are located. We should also show the confidence level with which gene is associated with the trait."
While I agree this could be helpful, gathering all of the information requested here is non-trivial. Will circle back to this later.
This is unfortunately beyond the scope of this study. It is not at all a trivial task to incorporate variant-level information. When I did this for a single gene in a single phenotype, it took me weeks to exact the information. This has not yet been automated.
Including variants in the figure also gives the false impression that we performed variant-level analyses.
Also:
Tasks
Difficulty: low
Difficulty: medium
Difficulty: high
include variant-level informationbeyond the scope of the study