search

neurogeriatricskiel / KielMAT

Python based toolbox for processing motion data
https://neurogeriatricskiel.github.io/KielMAT/
Other
6 stars 1 forks source link

Use of relative paths #11

Closed rmndrs89 closed 1 year ago

rmndrs89 commented 1 year ago

https://github.com/neurogeriatricskiel/NGMT/blob/9c034841e600e77e5367afe45087eebc8990a45f/ngmt/modules/icd/ICDA.py#L59C57-L59C57

@masoudabedinifar could you use relative paths, at least in the intermediate modules?

Best, Robbin

masoudabedinifar commented 1 year ago

Hello @rmndrs89,

Thank you for your suggestion. Sure, I will take care of using relative paths.

Best, Masoud.

masoudabedinifar commented 1 year ago

Hi @rmndrs89,

I updated GSD and ICD algorithms in dev-ICD branch and I already pushed them:

https://github.com/neurogeriatricskiel/NGMT/blob/dev-ICD/ngmt/modules/icd/ICDA.py https://github.com/neurogeriatricskiel/NGMT/blob/dev-ICD/ngmt/modules/gsd/GSDB.py https://github.com/neurogeriatricskiel/NGMT/blob/dev-ICD/ngmt/utils/preprocessing.py

Best, Masoud.

rmndrs89 commented 1 year ago

@masoudabedinifar maybe you can reference the commit at which you made the changes and then close this issue?

masoudabedinifar commented 1 year ago

Thank you @rmndrs89 , I am going to refer to the commits that I used relative path and then I am going to close the issue:

9fe333ef5cca47481979857ae51aacc9e0cd1bdf

[0e725b1fa5c2639dc11f81d958e4f275ce7617a9] (https://github.com/neurogeriatricskiel/NGMT/commit/0e725b1fa5c2639dc11f81d958e4f275ce7617a9)

masoudabedinifar commented 1 year ago

Relative path is used in GSD and preprocessing and the issue is closed.