neurogeriatricskiel / KielMAT

Python based toolbox for processing motion data
https://neurogeriatricskiel.github.io/KielMAT/
Other
6 stars 1 forks source link

Where to store subject and tracking system information? #88

Closed JuliusWelzel closed 2 months ago

JuliusWelzel commented 4 months ago

Motion-BIDS stores subject and tracking-system information in different .json files. We have in the NGMTRecording class currently only info implemented with three valid keys. Should we allow dictionaries from each tracking system where information about the device is stored?

JuliusWelzel commented 3 months ago

Implement this in the following way:

  1. Rename info attribute to recording_info
  2. combine information from filename (sub-, ses-, tracksys-) and motion.json in the recording_info
rmndrs89 commented 3 months ago

Please note that we don't always have that info in the filename, for example, for the Mobilise-D and IDEA-FAST datasets, it works a bit differently (as this is data from the home assessment), so be careful with writing a function to automatically extract it from the filename.

JuliusWelzel commented 3 months ago

I see. We should still provide the fields so people can add this info themselves for a valid BIDS export

JuliusWelzel commented 2 months ago

Done in https://github.com/neurogeriatricskiel/KielMAT/commit/bcab3307bc1981068ed55ba774f4e5bf288f5df1