neurogeriatricskiel / NGMT

Python based toolbox for processing motion data
https://neurogeriatricskiel.github.io/NGMT/
Other
6 stars 1 forks source link

Paper review #62

Closed JuliusWelzel closed 3 months ago

JuliusWelzel commented 3 months ago

Inputs

https://github.com/neurogeriatricskiel/NGMT/blob/802b9bf74807309915cc5c1b32d25548ca96ede0/paper/paper.md?plain=1#L55 Is the sampling frequency an optional input? I believe not. Rather the extra information for the channels df are optional, correct @rmndrs89?

Installation

https://github.com/neurogeriatricskiel/NGMT/blob/802b9bf74807309915cc5c1b32d25548ca96ede0/paper/paper.md?plain=1#L88 I would rewrite this as it can be cloned via GH but not installed. Also there is no text about how to contribute even as we point this out as a strength previously