Issues regarding GSD algorithm - Githubissues

neurogeriatricskiel / NGMT

Python based toolbox for processing motion data

https://neurogeriatricskiel.github.io/NGMT/

Other

6 stars 1 forks source link

Issues regarding GSD algorithm #70

Closed masoudabedinifar closed 3 months ago

masoudabedinifar commented 3 months ago

Dear all,

The issues that need to be addressed regarding the GSD algorithm before submitting the JOSS paper could be listed as follows:

Error handling for the cases such as [KeepControl][https://github.com/neurogeriatricskiel/NGMT/issues/66]

[x] Add error handling inside the algorithm to manage cases where there are fewer than 5 steps identified as gait sequences (such as tug data from KeepControl). Provide an error message such as: "Gait sequence(s) were not detected since there are not enough steps."

Attribute match Docs GSD

[x] The attributes in the docstring and init function do not match as mentioned here Attributes

Improvement should be done for GSD for the situations where we have less than 5 steps in the data such TUG from KeepControl dataset to handle them

[x] Handling cases such as [KeepControl][https://github.com/neurogeriatricskiel/NGMT/issues/66]

masoudabedinifar commented 3 months ago

The cases where there are fewer than 5 steps in the data are handled by popping up the error message: "No gait sequences detected due to insufficient steps in the data" with commit: feb4ca3f3d7b8c3fa1854a9788c7f638ea3ea8ba

masoudabedinifar commented 3 months ago

Attribute now matches with init by commit: 913c7bf03aa2142e034bf81f254f05f8d3f92da1

rmndrs89 commented 3 months ago

I have completed the third task, and therefore close this issue.