Move REQUIRED_COLUMNS to dataclass definition?

neurogeriatricskiel / NGMT

Python based toolbox for processing motion data

https://neurogeriatricskiel.github.io/NGMT/

Other

6 stars 1 forks source link

Move REQUIRED_COLUMNS to dataclass definition? #78

Closed rmndrs89 closed 2 months ago

rmndrs89 commented 2 months ago

https://github.com/neurogeriatricskiel/NGMT/blob/d6cbe3793e82d24902247d2426b4eae174f0909c/ngmt/datasets/keepcontrol.py#L8

Should we move this (global) variable to the ngmt_dataclass.py? It should hold across all datasets, and is not specific to keepcontrol in my view?

JuliusWelzel commented 2 months ago

+1 in favor of this!

rmndrs89 commented 2 months ago

REQUIRED_COLUMNS has been moved to utils/ngmt_dataclasses.py, the validate_channels method has been update accordingly, and REQUIRED_COLUMNS is now loaded with an import in the datasets/keepcontrol.py script.