neurogeriatricskiel / NGMT

Python based toolbox for processing motion data
https://neurogeriatricskiel.github.io/NGMT/
Other
6 stars 1 forks source link

Most of the example files not available #90

Open davidpagnon opened 3 weeks ago

davidpagnon commented 3 weeks ago

Hi,

The code is very well written and a pleasure to review, thanks for this effort!

However, most of the example files (at Home and examples and in the corresponding notebooks) are not available. It would be nice to upload them to https://github.com/neurogeriatricskiel/NGMT/tree/main/examples/data so that the new user can try out the code.

Not available:

Minor remark: the content of the ipynb files is not totally equivalent to the examples and modules on the website.

davidpagnon commented 3 weeks ago

In "Installation and usage" (L85 of the JOSS paper), it may be worth adding a line stating that the example data were gathered in accordance with the Declaration of Helsinki https://joss.readthedocs.io/en/latest/policies.html#joss-policies