search

neuroglancerhub / ng_workspaces

5 stars 5 forks source link

Fix up navigation pull down #20

Closed neomorphic closed 4 years ago

neomorphic commented 4 years ago

The button on the navigation bar now has the text to state its' intention and the button to show the navigation is now thei same color as the hidden navigation to tie them together and to make it stand out on black, white, and drab green color backgrounds.

hubbardp commented 4 years ago

My only concern is that "navigation" in the "HIDE NAVIGATION" text on the control seems a bit unclear to me. I guess choosing the workspace is not what I would have considered to be "navigation", and I wonder if others might be confused.

neomorphic commented 4 years ago

@hubbardp your concern seems reasonable. Do you have an alternative noun?

hubbardp commented 4 years ago

I almost think just "HIDE" would work.

neomorphic commented 4 years ago

I have these: "HIDE HUB HEADER" "FULLSCREEN"

hubbardp commented 4 years ago

"HIDE HUB HEADER" sounds a bit like it's trying to be cute. How about just "HIDE HEADER"?

hubbardp commented 4 years ago

Looks good to me. I say go ahead and merge it.