neuroinformatics-unit / HowTo

NIU website on common software problems and their troubleshooting
http://howto.neuroinformatics.dev/
Creative Commons Attribution 4.0 International
9 stars 1 forks source link

Modify actions #11

Closed niksirbi closed 1 year ago

niksirbi commented 1 year ago

Modifying GitHub workflow to use the latest versions of various actions. Once I'm sure actions are working, I will move them to the actions repo and call them from there.

adamltyson commented 1 year ago

I've approved, but not merged as it's still in draft.

niksirbi commented 1 year ago

Thanks. It's deliberately still in draft, I am planning to experiment a bit more with it

niksirbi commented 1 year ago

Update

Now the workflows reference actions in neuroinformatics-unit/actions. Currently pulling from the add-docs-workflow branch, but will switch to main after that PR is merged.

I ended up using two separate workflows:

It is possible to put both in a single workflow file and separate them with conditionals (e.g. github.event_name == "pull_request"), but then the GitHub actions report becomes more complicated because it also includes all the skipped actions (that did not satisfy the conditional).

PS

A neat new feature I discovered and smuggled into the render note with admonition directive commit: sphinx supports these pretty admonition boxes. They can be added in markdown using this syntax.