neuroinformatics-unit / HowTo

NIU website on common software problems and their troubleshooting
http://howto.neuroinformatics.dev/
Creative Commons Attribution 4.0 International
9 stars 1 forks source link

Logo and style changes #12

Closed lauraporta closed 1 year ago

lauraporta commented 1 year ago

Working on #9

lauraporta commented 1 year ago

I was trying to make style changes by editing the repo with our future sphinx theme, but it will still take a while to make it functional (PR #1). So, I can now test the palette only by directly adding a custom.css file here.

I am following PyData docs.

Here is how it looks for dark and light theme. I might have chosen too flashy colours for the dark one. I don't yet know where --pst-color-secondary is used.

Screenshot 2022-12-06 at 15 43 14 Screenshot 2022-12-06 at 15 46 33
adamltyson commented 1 year ago

I like it. I have no idea whether it's better to add a css file here or try to get the custom theme working though.

lauraporta commented 1 year ago

@niksirbi what do you think of the colours? Once we define here our custom.css we could then port it to neuroinformatics-sphinx-theme.

lauraporta commented 1 year ago

@adamltyson I think that now that we have few websites and small lines of code to add we are ok without our own sphinx theme. In the future it might simplify our work

niksirbi commented 1 year ago

Nice work, I like the look! Two comments on the colors:

niksirbi commented 1 year ago

I think for now it's OK to have the CSS on each repo level, but I suspect it will get out of hand soon if we keep adding modifications. My suggestion would be: prototype here (as you are already doing), and port to the neuroinformatics-sphinx-theme once satisfied. All other docs repos should inherit their style from there.

lauraporta commented 1 year ago

@niksirbi if I keep the matrix green for the dark theme, I think that readability decreases, this is why I kept it only for the light theme 🥲 I could change the green of the logo depending on the theme (no yet sure how to). What do you think? Regarding yellow, I just opted to it to differentiate with the blue-pink colour scheme of PyData theme. I can revert to the original pinks.

niksirbi commented 1 year ago

@lauraporta I totally get the reason for making the green brighter on the dark theme. I think figuring out how to change the logo depending on the theme will be quite tricky. We can either leave it as it is now, or you can try to decrease the brightness of that green a little bit (so brighter than the matrix green, but darker than the current value), so that the difference with the logo is not so easily perceptible to the human eye. If that doesn't work out, leave it as is.

Regarding the yellow/purple issue, I personally prefer the PyData purples for inline code stuff. They obviously spent some time on finding the colours that work, and I think there is no need to differentiate ourselves from them in every aspect of branding.

lauraporta commented 1 year ago

Let's compare some darker green shades:

05F092

Screen Shot 2022-12-08 at 3 53 56 PM

04DC86

Screen Shot 2022-12-08 at 3 56 26 PM

04C87A

Screen Shot 2022-12-08 at 3 58 18 PM

04B46D

Screen Shot 2022-12-08 at 3 59 33 PM

03A062 (matrix)

Screen Shot 2022-12-08 at 4 00 40 PM
lauraporta commented 1 year ago

I think #04B46D might be a good compromise!

niksirbi commented 1 year ago

I like both #04C87A and #04B46D ! Still legible and not too far from the logo color

lauraporta commented 1 year ago

OK great! Thanks