Closed niksirbi closed 12 months ago
Out of interest, why this way, rather than the reviewers building locally
Just my neglect. I started working on this very long ago, when not all of us were super familiar with sphinx local builds and I intended to make life easier for reviewers.
But now that we are all such Sphinx pros, there is no need to do that, and I should stop doing it. I had just forgotten that it was configured "the old way" on this branch, and I only realised after the build went public 😨
@niksirbi the bigger problem is the continued insane GitHub bug that ended up with you updating my comment!?!
@niksirbi the bigger problem is the continued insane GitHub bug that ended up with you updating my comment!?!
exactly, it almost happened again, but I realised it in time now
@niksirbi I also don't get why we can edit each others comments anyway. I can use the dropdown to edit your messages using the GitHub UI. Is it because of the permissions we have for the repo?
@niksirbi I also don't get why we can edit each others comments anyway. I can use the dropdown to edit your messages using the GitHub UI. Is it because of the permissions we have for the repo?
Maybe because we are all admins. Should I set neuroinformatics-all
as maintainers?
Maybe because we are all admins. Should I set neuroinformatics-all as maintainers?
yeah that sounds good. Especially as this is the new, larger set of contributors.
Maybe because we are all admins. Should I set neuroinformatics-all as maintainers?
yeah that sounds good. Especially as this is the new, larger set of contributors.
Done, do you still have permission to edit my posts (you shouldn't now)?
Done, do you still have permission to edit my posts (you shouldn't now)?
I do, but I'm admin of the whole org, so I guess that's expected (but still weird).
Done, do you still have permission to edit my posts (you shouldn't now)?
I do, but I'm admin of the whole org, so I guess that's expected (but still weird).
Crazy. Anyway, yell at me if I accidentality edit any comments and I'll try to be more careful. I really don't think we should be editing what other people say!
This PR adds two how-to guides:
Other than that, there are some small bits and pieces, like:
sphinx-copybutton
to enable copy-pasting from our code-blocksI would suggest @lochhh looks at the SLEAP part, because she has seen an earlier version of it already, and @adamltyson reviews the SLURM bit, as it might be useful/relevant for the upcoming HPC course.
The best way to review this is to directly look at the rendered website build. I've temporarily overridden the workflow rules to allow publication from this PR, which means that I have to: