search

neuroinformatics-unit / datashuttle

Tool for the creation, validation and transfer of neuroscience project folders.
https://datashuttle.neuroinformatics.dev/
BSD 3-Clause "New" or "Revised" License
14 stars 3 forks source link

Unpin sphinx 7.2 #398

Closed JoeZiminski closed 3 months ago

JoeZiminski commented 3 months ago

This PR unpins sphinx, closes #397 that describes the issue.

Tested locally and it builds OK, docs look good. No tests or further documentation required. However, in the new style, the dropdown menus all have a thick green border around them. I will probably turn this off unless @neuroinformatics-unit/neuroinformatics-all particularly likes them (for me it makes the pages look too busy):

image

niksirbi commented 3 months ago

I kinda see why they introduced the green borders. Previously, it was not super clear to see where the content of a tab/dropdown ended and the "normal" content began. There was a faint horizontal line in between, but at a glance it was not easy to see what belongs to the tab and what not. So I'd be in favour of keeping them despite the visual "clutter" they add, but I don't feel too strongly about this.

niksirbi commented 3 months ago

The public datashuttle.neuroinformatics.dev already has the green borders btw and imo it looks ok. I think this is due to a Pydata Sphinx Theme update, not related to the pinned Sphinx version per se.

lochhh commented 3 months ago

I kinda see why they introduced the green borders. Previously, it was not super clear to see where the content of a tab/dropdown ended and the "normal" content began. There was a faint horizontal line in between, but at a glance it was not easy to see what belongs to the tab and what not. So I'd be in favour of keeping them despite the visual "clutter" they add, but I don't feel too strongly about this.

The reason is for accessibility.

niksirbi commented 3 months ago

Good to know they are taking such a considered and systematic approach to design! I'm glad we have hopped on the pydata-sphinx-theme bandwagon.

JoeZiminski commented 3 months ago

Nice! Thanks both lets keep them good spot @lochhh. Oh yes indeed sphinx-argparse is no longer required, will make a quick follow-up PR cheers.