neuroinformatics-unit / movement

Python tools for analysing body movements across space and time
http://movement.neuroinformatics.dev
BSD 3-Clause "New" or "Revised" License
77 stars 7 forks source link

Add viz extras to xarray dependency #161

Closed niksirbi closed 2 months ago

niksirbi commented 2 months ago

Description

What is this PR

Why is this PR needed? Closes #158 . Thanks @antortjim for reporting the bug.

What does this PR do?

We now depend on xarray[accel,viz], instead of just xarray[accel], meaning we also require matplotlib and seaborn.

Accordingly, matplotlib is no longer listed as an additional dependency for docs and binder (no need, since it will now come bundled with movement).

References

See #158 and xarray's installation instructions.

How has this PR been tested?

Example notebooks were run in a fresh environment.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No.

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.66%. Comparing base (a97ae86) to head (8dc0a4e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #161 +/- ## ======================================= Coverage 99.66% 99.66% ======================================= Files 10 10 Lines 605 605 ======================================= Hits 603 603 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud