neuroinformatics-unit / movement

Python tools for analysing body movements across space and time
http://movement.neuroinformatics.dev
BSD 3-Clause "New" or "Revised" License
77 stars 7 forks source link

Fix installation link and add quick install #185

Closed sfmig closed 1 month ago

sfmig commented 1 month ago

Description

What is this PR

Why is this PR needed? Installation link was returning 404

What does this PR do? Fixes installation link and adds quick install instructions.

References

\

How has this PR been tested?

\

Is this a breaking change?

\

Does this PR require an update to the documentation?

\

Checklist:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.68%. Comparing base (b2de775) to head (3f90072).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #185 +/- ## ======================================= Coverage 99.68% 99.68% ======================================= Files 11 11 Lines 638 638 ======================================= Hits 636 636 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sfmig commented 1 month ago

Questions/suggestions:

adamltyson commented 1 month ago

There's already link checking right via sphinx?

sfmig commented 1 month ago

yeah, but I think atm it doesn't include the repo's README. Is that right @niksirbi?

adamltyson commented 1 month ago

Oh yeah, sorry. That is correct (I think).

niksirbi commented 1 month ago

I think the two questions are related. If we keep the README minimal, as is now, I don't see much value in adding more automated checks specifically for it. If we decide to add more stuff to the README, e.g. the installation instructions that Sofia suggests, additional checks would useful.

I'm undecided on this. I agree that having the installation instructions "right there" in the README is convenient, and commonly done for other tools, but it increases the probability of things getting out of sync. There are some workarounds, like including a specific snippet of text from the README into the docs, but they are hacky and will preclude us from using the fancy sphinx-design elements.

Happy to go with whatever the majority of @neuroinformatics-unit/behaviour thinks...

adamltyson commented 1 month ago

My view is:

niksirbi commented 1 month ago

In that case, I'm happy with @sfmig adding the "Quick install" section to the README, as described above.

sfmig commented 1 month ago

Sounds good! Will add it to this same PR if that's ok

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sfmig commented 1 month ago

@niksirbi I had a go at removing the "table of contents" section, to have the quick install almost at the top and keep the README short - let me know what you think.

niksirbi commented 1 month ago

Sounds good, I'm deep in atlas-land at the moment, so I'll review this tomorrow.