neuroinformatics-unit / movement

Python tools for analysing body movements across space and time
http://movement.neuroinformatics.dev
BSD 3-Clause "New" or "Revised" License
77 stars 7 forks source link

Suggestion to rename private loader #187

Closed sfmig closed 1 month ago

sfmig commented 1 month ago

Description

What is this PR

Why is this PR needed? We have two private data loading functions to read DLC files into a dataframe: _parse_dlc_csv_to_df and _load_df_from_dlc_h5.

This PR proposes to rename one of them (_parse_dlc_csv_to_df -> _load_df_from_dlc_csv) , for a more consistent naming of the two.

What does this PR do? Renames a private data loading function.

References

\

How has this PR been tested?

Tests pass locally and in CI.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No because it is a private function.

Checklist:

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.68%. Comparing base (b2de775) to head (4023a02).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #187 +/- ## ======================================= Coverage 99.68% 99.68% ======================================= Files 11 11 Lines 638 638 ======================================= Hits 636 636 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.