neuroinformatics-unit / movement

Python tools for analysing body movements across space and time
http://movement.neuroinformatics.dev
BSD 3-Clause "New" or "Revised" License
77 stars 7 forks source link

Add the option for multiple views loading #197

Open vigji opened 1 month ago

vigji commented 1 month ago

Description

This PR attempts at defining a loading mode for supporting multi-camera data.

This kind of data structure would be needed by anyone in the process of extracting 3D poses. This is something needed only as long as you do not have yet 3D coordinates, in my case (but I assume in anyone's) the end goal of having multiple views. So, if you want to support only the final, "clean" data where some triangulation of sort already happened, I would understand!

References

Discussion started in #196

How has this PR been tested?

Currently in the process of defining tests, atm just with already existing data, pretending it to be multi-camera.

Is this a breaking change?

If we decide to approve this, it will require some core redefinition in the dataset validator. Currently it seems to be quite strict; if the view dimension ends up being optional, it would require some work in the Validator class. I am not familiar with the processing functions to compute kinematics, in principle I assume the semantic indexing of xarray should allow for a smooth handling of this optionality - but I am not yet an xarray pro

Does this PR require an update to the documentation?

If accepted, yes.

If any features have changed, or have been added. Please explain how the documentation has been updated.

No changes yet

Checklist:

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.68%. Comparing base (426003c) to head (9a57287).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #197 +/- ## ======================================= Coverage 99.68% 99.68% ======================================= Files 11 11 Lines 638 643 +5 ======================================= + Hits 636 641 +5 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

niksirbi commented 1 month ago

Cross-linking this thread on Zulip, where we are discussing matters relevant to this PR.