This was brought up by @vigji during this discusssion on zulip.
When computing a kinematic variable, e.g. via movement.analysis.kinematics.compute_velocity(), only the time dimensions should be validated, I think that was the intention behind the _validate_time_dimension utility created by @lochhh.
However, when calling the same function via the accessor, i.e ds.move.compute_velocity, the underlying code contains a call to the .move.validate() method, which validates all dimensions. So it seems like we get different behaviour if we use the accessor vs directly using the functions from the kinematics module.
We haven't yet decided how we'll address the issues raised in the aforementioned zulip discussion, but I think we should remove that validator call regardless. Or is it playing some integral role I've missed?
This was brought up by @vigji during this discusssion on zulip.
When computing a kinematic variable, e.g. via
movement.analysis.kinematics.compute_velocity(), only thetimedimensions should be validated, I think that was the intention behind the_validate_time_dimensionutility created by @lochhh.However, when calling the same function via the accessor, i.e
ds.move.compute_velocity, the underlying code contains a call to the.move.validate()method, which validates all dimensions. So it seems like we get different behaviour if we use the accessor vs directly using the functions from thekinematicsmodule.We haven't yet decided how we'll address the issues raised in the aforementioned zulip discussion, but I think we should remove that validator call regardless. Or is it playing some integral role I've missed?