Refactor validators tests

sfmig commented 3 weeks ago

Description

What is this PR

[ ] Bug fix
[ ] Addition of a new feature
[x] Other

Why is this PR needed? A suggestion to simplify the structure of the validators tests.

What does this PR do?

Splits file validators tests and dataset validators tests (following #204)
Removes the class for the validators tests - feel free to shoot this down, but I wasn't sure why the test suite was made into a class.

I also considered moving a large fixture from dataset validator tests to conftest to reduce length, but in the end I opted for keeping all together for now. But going forward we may want to organise a bit the fixtures, maybe do something like this instead (we do that in 🦀 s).

References

PR #204

How has this PR been tested?

Tests pass locally and in CI.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No.

Checklist:

[x] The code has been tested locally
[ n/a ] Tests have been added to cover all new functionality
[ n/a ] The documentation has been updated to reflect any changes
[x] The code has been formatted with pre-commit

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.70%. Comparing base (bba9403) to head (d6733a5).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #207 +/- ## ======================================= Coverage 99.70% 99.70% ======================================= Files 12 12 Lines 678 678 ======================================= Hits 676 676 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.