neuroinformatics-unit / movement

Python tools for analysing body movements across space and time
http://movement.neuroinformatics.dev
BSD 3-Clause "New" or "Revised" License
96 stars 8 forks source link

Remove `defaults` from test_and_deploy.yml #275

Closed sfmig closed 1 month ago

sfmig commented 1 month ago

Description

What is this PR

Why is this PR needed? We are currently using the defaults channel in our actions, which from Aug2024 is not free to use for our case

What does this PR do? Add nodefaults channel to prevent from using the defaults channel. See docs

References

\

How has this PR been tested?

The CI in this PR shows the default channel is omitted.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

Should we include this in our docs for our users?

Checklist:

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.77%. Comparing base (abeaff1) to head (af3a910). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #275 +/- ## ======================================= Coverage 99.77% 99.77% ======================================= Files 14 14 Lines 883 883 ======================================= Hits 881 881 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adamltyson commented 1 month ago

Probably not? I'd say it's not our job to tell everyone how to configure conda.

I would say our job ends once we've pointed users in the right direction. I.e. we should recommend miniforge, but not miniconda. Other than that, it's up to them. Based on recent comments from Anaconda, I don't even know who can and can't use the default channels for free anymore anyway!

niksirbi commented 1 month ago

Probably not? I'd say it's not our job to tell everyone how to configure conda.

I would say our job ends once we've pointed users in the right direction. I.e. we should recommend miniforge, but not miniconda. Other than that, it's up to them. Based on recent comments from Anaconda, I don't even know who can and can't use the default channels for free anymore anyway!

Our installation instructions begin by assuming people already have conda/mamba installed. Do you recommend mentioning to install conda via miniforge (in case they don't already have it installed)?

adamltyson commented 1 month ago

Our installation instructions begin by assuming people already have conda/mamba installed. Do you recommend mentioning to install conda via miniforge (in case they don't already have it installed)?

I think that's fine. I think we should just recommend miniforge if we recommend a distribution.