Closed niksirbi closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.76%. Comparing base (
7813e7c
) to head (c7356dc
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @sfmig, thanks for sending me down a 🐰 🕳️
I ended up writing such a script (using yours as a starting points). Not sure it's worth it, since for the sake of 2 admonitions we now have to maintain an entire script, bit I lean towards using the script anyway. My reasoning is that in the future we may build upon it to do some more intelligent parsing from README.md
to index.md
, in a way that further reduces duplication (not just across admonitions).
I like it! You took it to the next level! 🚀
we now have to maintain an entire script
True! But maybe maintaining a script is better than remembering both sources of text need to be in sync?
we may build upon it to do some more intelligent parsing from README.md to index.md, in a way that further reduces duplication.
That sounds like a nice idea.
Quality Gate passed
Issues 1 New issue
Just a reminder here to check this
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Thanks both! I've now refactored the conversion script to reduce its cognitive complexity. I think this is now ready to merge.
Description
What is this PR
Why is this PR needed?
Closes #305
What does this PR do?
Adds a "tip" admonition to the README and the website homepage. Sadly I had to duplicate the text in both places, because the syntax for creating admonition boxes is different in GitHub-flavored vs myst-markdown. We could do away with the duplication if we went for simpler rendering options, but I like how the admonitions look.
How has this PR been tested?
Local docs build.